search

studentquiz / moodle-mod_studentquiz

Moodle-Plugin
GNU General Public License v3.0
38 stars 37 forks source link

StudentQuiz: There are some issues of Add completion criteria #732619 #474

Closed BruceGoodGuy closed 9 months ago

BruceGoodGuy commented 9 months ago

Hi @timhunt, I have made a necessary changes to fix the issue with Studentquiz. Could you help me to review my code changes? thanks so much. Commit ID: 7b1dd5d05f46892afa92fb8d10bb09172beaefe0

BruceGoodGuy commented 9 months ago

Hi @timhunt ,

Thanks for your feedback.

In this commit, I have made two changes:

  1. Rename the function update_state to trigger_completion_state_update.

  2. Rewrite unit-test for the function trigger_completion_state_update. Could you help me to review it again? Thanks so much. Commit ID: 43e361d85e74fad36a4dee561fd338004a757326

timhunt commented 9 months ago

Thanks. Merged.