Closed danghieu1407 closed 8 months ago
Just to note, this patch was extremely difficult to understand, and the explanation above did not help.
To explain properly:
continue-on-error: true # This step will show errors but will not fail
to the Moodle PHPDoc Checker step in .github/workflows/ci.yml. (You can find examples of that in other plugins.)Once you have solved points 2, 3 and 4 this should be ready to merge.
Hello @timhunt,
I've updated the code addressing points 2 and 3. Regarding point 4, upon rebasing, I noticed it had already been added by you. I apologize for squashing with the old commit.
The changes are now ready for your review. Could you please take a look? Many thanks
from general delete/edit management #727398
Hi @timhunt, I have eliminated the "edit" capability in changestate.php. Additionally, I have adjusted the condition in renderer.php so that the button for changing the state is rendered only if the user has the capability to edit or possesses the capability "mod/studentquiz:changestate." In the Behat testing, I have excluded the "mod/studentquiz:manage" capability to ensure that users with the "mod/studentquiz:changestate" capability are specifically able to change the state. Could you please review this change? Many thanks.