[M4.3] Default activity completion page in Couse completion setting b…

studentquiz / moodle-mod_studentquiz

Moodle-Plugin

GNU General Public License v3.0

38 stars 37 forks source link

[M4.3] Default activity completion page in Couse completion setting b… #487

Closed danghieu1407 closed 4 months ago

danghieu1407 commented 4 months ago

…roken #778312

Hi @timhunt, I have added the suffixed name for the function add_completion_rules if the Moodle version is greater than 4.2. Due to behat function being deprecated in 4.4, I have added a new behat function to support all versions. I have updated the behat fail of studentquiz. Step "And I click on "New" "link" because in Moolde 4.4, we have a link "new section" which causes the behat to click the wrong link. Could you please have a look at this change? Many thanks.

timhunt commented 4 months ago

The actual fix is good.

The Behat changes are a problem. behat_course::i_add_to_section was added in Moodle 4.1 (MDL-79029). No need to define a custom Behat step.

We can drop support for Moodle 4.0 now. It has not been supported by Moodle for ages: https://moodledev.io/general/releases.

danghieu1407 commented 4 months ago

Hi @timhunt, Thanks for your review. Based on your review, I have removed the 4.0. Also I have removed the custom behat and updated the behat. Could you please have a look at this change? Many thanks