search

studio-arrenberg / quartiersplattform

🏡 Repo für die Quartiersplattform
https://arrenberg.app
MIT License
2 stars 3 forks source link

When updating translations (Ultimate Member) it errors out #127

Open Uatschitchun opened 2 years ago

Uatschitchun commented 2 years ago

My Dashboard shows 2 new updates. One of them is translation updates for UM. When I try to update, this is what I get:

Danke für dein Vertrauen in WordPress.Version 6.0

Warning: Cannot modify header information - headers already sent by (output started at /folder/in/my/webspace/wordpress/wp-includes/functions.php:5275) in /folder/in/my/webspace/wordpress/wp-content/themes/quartiersplattform-1.8.2/functions.php on line 3305

Warning: Cannot modify header information - headers already sent by (output started at /folder/in/my/webspace/wordpress/wp-includes/functions.php:5275) in /folder/in/my/webspace/wordpress/wp-content/themes/quartiersplattform-1.8.2/functions.php on line 3305

Warning: Cannot modify header information - headers already sent by (output started at /folder/in/my/webspace/wordpress/wp-includes/functions.php:5275) in /folder/in/my/webspace/wordpress/wp-content/themes/quartiersplattform-1.8.2/functions.php on line 3305

Warning: Cannot modify header information - headers already sent by (output started at /folder/in/my/webspace/wordpress/wp-includes/functions.php:5275) in /folder/in/my/webspace/wordpress/wp-content/themes/quartiersplattform-1.8.2/functions.php on line 3305

and the update does not complete!?

It's this function:

/**
 * QP language function
 * 
 * @since Quartiersplattform 1.7.3
 * 
 * @return language string
 */
function qp_language()
j0hannr commented 1 year ago

@Uatschitchun Does this happen when updating the Transplation strings?

They are currently poorly embedded into the system, do you know how to improve this?

Uatschitchun commented 1 year ago

@j0hannr No, no idea. Have done gettext translations in OpenSource projects, but not in wordpress.

Uatschitchun commented 1 year ago

Maybe it would be a good idea, in the long run, to use something like transifex to open up translations to the community?

j0hannr commented 1 year ago

@Uatschitchun translations are not easy. Transifex unfortunately costs money, so we will have to work with out it currently.

Uatschitchun commented 1 year ago

@j0hannr Have a look here: https://docs.transifex.com/projects/open-source-project Only thing required for a free plan is an appropriate license...

Uatschitchun commented 1 year ago

As of today I noticed again translation updates for UM which do install fine as it is stated in backend, but re-appear again when going to the update page. Haven't had the chance to look into logs.

j0hannr commented 1 year ago

Yes, that's because they are not properly included into WordPress. I could not find best practices at the time of development. I should look into it, when we change translations, add more languages or have more platforms that use the plugin.

Updating the translation asynchronous to the plugin via the internet would be interesting and I think is possible through WordPress.