Closed ueffel closed 1 year ago
Hello @ueffel
Thank you for your request!
Yes, option 2 offers the most flexibility but also ties our lib up. Same for option 3.
Any thoughts left?
Pull request welcome!
No other thoughts. I pull requested option 1.
Awesome!
Hello Collaborators,
can we add the ability to set the
CookieJar
of the internalhttp.Client
of thegowebdav.Client
? I got proprietary webdav server, which does authentication via kerberos. It is way faster to use the cookie after the initial authentication than to reauthenticate at every request.I see 3 possibilities to implement this:
provide a
SetJar
method for thegowebdav.Client
like thisexpose the internal
http.Client
by making thec
field public or add an option togowebdav.NewClient
so a configuredhttp.Client
for the webdav client to use can be provided.use the
http.DefaultClient
ingowebdav.NewClient
function to initialize thec
field.I like number 2. with an option to provide a
http.Client
best, because it adds the most flexibility. Maybe there is a good reason why the library uses its own cleanhttp.Client
that I don't see right now. In that case I would like number 1 implemented.Thoughts?
(I can provide the pull request if we reach a decision)