search

studio-cartogram / studioself

0 stars 0 forks source link

Image margins #8

Closed cartogram closed 7 years ago

cartogram commented 7 years ago

Sorry to change my mind on this again, but I think the margins on the project page should be 18%. I did some looking around at some other sites and I think this is the sweet spot! Also, I just noticed that even though we discussed 20% its actually a bit more than that in chrome, like around 22% or something. I just want to make its bang on 18%, since we’ve spent the time deliberating this, haha.

MattSelf commented 7 years ago

Hey guys, looks like the project page margins were altered when the viewport sizing was deployed. Could you change it back to 18% of the window width? Also, on mobile devices, the margins have also been increased. Could they be changed back also? Thanks

feeohnah commented 7 years ago

@cartogram I still think there needs to be some padding between images, the sketch file is pretty consistent with ~60px between each image and ~74 px between each row.

screen shot 2017-06-25 at 6 40 11 pm screen shot 2017-06-25 at 6 43 04 pm
MattSelf commented 7 years ago

The homepage needs to have consistent padding between images, right now it fluctuates based on the window dimension. The only variable would be the outer margins between images and the window edges. The padding should always be 60 between images and 75 (or 74) between rows.

MattSelf commented 7 years ago

Some strange things happening at mobile sizes too, where the images are not scaling down to the correct width. See screenshot attached. Alos, I swear I wrote about this already but I can't find my previous comment, maybe I didn't hit the 'comment' button. So please ignore if this is doubling up.

screen shot 2017-06-27 at 11 44 13 am
feeohnah commented 7 years ago

@MattSelf can you confirm if we've resolved the mobile issue you were seeing?

The other is related to this https://github.com/studio-cartogram/studioself/issues/21

MattSelf commented 7 years ago

Mobile is working really well, all the padding and spacing is great.

On Wed, Jul 5, 2017 at 12:56 PM, Fiona notifications@github.com wrote:

Closed #8 https://github.com/studio-cartogram/studioself/issues/8.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/studio-cartogram/studioself/issues/8#event-1151295054, or mute the thread https://github.com/notifications/unsubscribe-auth/AbbwRf3C_xHKh1KygwksAi2t2tr6gDdHks5sK8A6gaJpZM4NYc0g .