studio-minus / ppg-bugs-and-requests

Bug report issue tracker
21 stars 26 forks source link

One-way liquid pipe, Blood Vessel Wire rename, Rigid liquid pipe/one-way pipe #2093

Open Pyrolyzed opened 2 years ago

Pyrolyzed commented 2 years ago

Feature description Rename the "Blood Vessel Wire" to "Liquid Pipe" or "Liquid Wire". Add a one-way version of the Liquid Pipe Add a rigid, non-flexible version of both the normal liquid pipe, and the one-way liquid pipe.

Feature purpose The rename is to fit the new purpose of these wires better, as now there are many, many liquids that the wires will be transferring in normal use, and not just blood, and not always between organisms.

The one-way pipe is to allow better control of liquid flow, and to stop the issue where flow between a tank, a object, and a valve will end up in a state where 50% of the tank is full, and 50% of the other object is full. The same goes for any other combination of liquid objects.

The rigid pipe is really just for looks, and is the same as using a Wire for a constraint versus using a Rigid Wire.

Additional context There is already a mod that did this, but has since stopped functioning. So this is certainly possible, and from my quick glance at the mods code, easy.

DindinYT37 commented 2 years ago

Multi-requesting will majorly decrease the chances of the request being accepted. Please don't multi-request.

Pyrolyzed commented 2 years ago

Multi-requesting will majorly decrease the chances of the request being accepted. Please don't multi-request.

These feature requests are so similar it would almost be cluttering the issue list to make them separate. Especially the rename. Also, you don't seem to work for Studio Minus, how do you know "multi-requesting" will do anything negative?

DindinYT37 commented 2 years ago

Multi-requesting will majorly decrease the chances of the request being accepted. Please don't multi-request.

These feature requests are so similar it would almost be cluttering the issue list to make them separate. Especially the rename. Also, you don't seem to work for Studio Minus, how do you know "multi-requesting" will do anything negative?

Separate issues aren't cluttering. I know because zooi has mentioned it a lot of times before.

mestiez commented 1 year ago

Grouping requests is usually not a good idea. It's a lot clearer for everyone to submit one request per actual request.

mestiez commented 1 year ago

I only want to accept the renaming request but now I can't without accepting the whole thing.