studio-minus / ppg-bugs-and-requests

Bug report issue tracker
21 stars 26 forks source link

Dialog boxes should only pop up if no other dialog box is present, and the escape menu should be accessible while one is open #568

Open Aspa102 opened 2 years ago

Aspa102 commented 2 years ago

Feature description When a request to open a dialog box is made, it should check if no other dialog box is open. The escape menu should also be allowed to be opened while one is open (or just have it so it can be opened no matter what really)

Feature purpose Having only one dialog box open at a time would prevent annoying stuff from having like a million of them open (you have to be an idiot for that to happen). It also helps when a person has a context button that opens a dialog box, and someone selects every limb and presses the button, opening 14 dialog boxes at once.

Having the escape menu accessible no matter what prevents softlocks from mods which either stop the menu from being opened with a dialog box that is unable to be closed / interacted with (MPP does this with the snap stuff which causes a canvas to appear in front of everything, and slowly fades out after a second. Pausing the game and opening a dialog box at the same time causes a softlock), or an error that creates a dialog box every time a dialog box is closed (this will most likely never happen).

Additional context Just was thinking back to when I had like a human with a context menu button for every limb that was meant to be used once, but everyone selected every limb and complained that they couldn't close the box.

mestiez commented 2 years ago

Some dialog boxes are absolutely necessary to be shown, though. What would happen in a situation where a dialog box says "hello :)", opened by some mod, is blocking a very important message from showing?

Aspa102 commented 2 years ago

Maybe an internal boolean can be used to override performing the check, I guess? Eh, it's sort of more a small issue that isn't very important.