Support s3 drivers for social_images disk

studio1902 / statamic-peak-seo

Belongs to the Statamic Peak Starter Kit and contains all SEO fieldsets and partials.

GNU General Public License v3.0

11 stars 14 forks source link

Support s3 drivers for social_images disk #17

Closed SanderGo closed 1 year ago

SanderGo commented 1 year ago

Changes proposed in this pull request:

As discussed in https://github.com/studio1902/statamic-peak-seo/discussions/16

It adds a check for s3 driver when saving Browsershot in the GenerateSocialImagesJob. When using s3 disk, it puts the screenshot. When using local driver it just saves the image like before.

Tested with a fresh install of Peak, using both local disk and s3 disk. Generated the social images in both cases as expected.

robdekort commented 1 year ago

Wonderful. Thank you.

SanderGo commented 1 year ago

Looks like we need to update the same thing for generating the Twitter image, on line 87. Not sure why it didn't cause trouble while testing before.

Want me to test and PR an update for it?

robdekort commented 1 year ago

Ahh. Yes please :)