search

studio1902 / statamic-peak-seo

Belongs to the Statamic Peak Starter Kit and contains all SEO fieldsets and partials.
GNU General Public License v3.0
11 stars 14 forks source link

Added no_Sandbox() option and workflow for use with Browsershot/Puppeteer #44

Closed mbootsman closed 3 months ago

mbootsman commented 3 months ago

Discussed on Discord: https://discord.com/channels/793146959635939329/1226853044738592909/1245719107370881044

I'm not a PR pro, so if anything is off, please let me know.

robdekort commented 3 months ago

Looks good. Thank you. What does the withoutOverlapping middleware do exactly? Any downsides or only ups?

robdekort commented 3 months ago

I think the toggle still needs:

if:
    use_social_image_generation: 'equals true'
mbootsman commented 3 months ago

Looks good. Thank you. What does the withoutOverlapping middleware do exactly? Any downsides or only ups?

AFAIK this makes sure jobs are done in a sequential way, and not overlap.

robdekort commented 3 months ago

AFAIK this makes sure jobs are done in a sequential way, and not overlap.

Sounds good.