Change dangling comma rule to allow when it's multiline

studiobakers / eslint-config-base

Bakers Studio's base ESLint rules

0 stars 0 forks source link

Change dangling comma rule to allow when it's multiline #10

Closed brkn closed 4 years ago

brkn commented 4 years ago

Request for discussion

Can we change this rule to enforce dangling commas when it's multiline?
This change would reduce diff line number, and remove unnecessary green or red highlighted lines at pr review when it is only a comma added or removed at the end of line.

mucahit commented 4 years ago

Thanks @brkn

I'm not sure about this, it feels a bit odd to me seeing a comma at the end of the array/object.

Since it affects all of the projects in which are this package is used, it's gonna be a major update. I'm voting to let's discuss on the next meeting.

bilgeyucel commented 4 years ago

I'm not sure about this, it feels a bit odd to me seeing a comma at the end of the array/object.

Totally agree on this. I will add it to our meeting topics.

bilgeyucel commented 4 years ago

We decided not to have this change.