search

studiobakers / eslint-config-base

Bakers Studio's base ESLint rules
0 stars 0 forks source link

Upgrade ESLINT to 7.5.0 #12

Closed edizcelik closed 4 years ago

edizcelik commented 4 years ago

Currently we require projects to have 6.x.x however as v7 is available now, we need to upgrade our configuration. While doing this we need to add/change the following rules:

"no-use-before-define": ["error", { "functions": false, "classes": true }],
"camelcase": 0

I want to disable camelcase rule as it creates issues when typing the api models in TypeScript projects:

ERROR in src/core/network-manager/networkModels.ts 11:3-19
camelcase: Identifier 'fallback_message' is not in camel case.
     9 |   type: ArrayToUnion<typeof ERROR_TYPES>;
    10 |   detail: ApiErrorDetailShape;
  > 11 |   fallback_message: string;
       |   ^^^^^^^^^^^^^^^^
    12 | }
bilgeyucel commented 4 years ago

These two changes will be implemented with PR #13. In the scope of this issue, I will be bumping up the eslint version and removing the redundant rules it there is any.