search

studiobakers / eslint-config-base

Bakers Studio's base ESLint rules
0 stars 0 forks source link

Enable `import/order` Rule #8

Closed mucahit closed 4 years ago

mucahit commented 5 years ago

We discussed with @edizcelik about this rule and I think import/order isn't active in common ESLint configs. If so, let's enable.

"import/order": [
  "error",
  {
    "groups": [
      [
        "external",
        "internal"
      ],
      [
        "sibling",
        "parent"
      ]
    ],
    "newlines-between": "always"
  }
],
brkn commented 4 years ago

What's the update about this, why did we removed it back at this commit? https://github.com/Hipo/eslint-config-hipo-base/commit/d1001d5acffe8b7d400b118a0ef58f4cf0d31ceb

edizcelik commented 4 years ago

I don't remember why we rolled back on these rules after adding them. @mucahit any idea ? I think we can close this.

mucahit commented 4 years ago

I don't remember why we rolled back on these rules after adding them. @mucahit any idea ? I think we can close this.

I'm not sure, it seems it's not an issue anymore. Closing this.