search

studiobakers / react-ui-toolkit

Bakers Studio's React-based UI Toolkit
MIT License
15 stars 2 forks source link

Input: `has-error` and `is-disabled` classnames should be added to the container #107

Closed edizcelik closed 3 years ago

edizcelik commented 3 years ago

Currently they are just added to the Input. However, to make the component more customizable, we need to add these classes to the container. For example, a user of this component may want to change the color of an icon provided to the component (as leftIcon or rightIcon).

yasincaliskan commented 3 years ago

Of course! So, should it be input-container--has-error and input-container--is-disabled?

edizcelik commented 3 years ago

Yes.

mucahit commented 3 years ago

Released https://github.com/Hipo/react-ui-toolkit/releases/tag/1.0.0-alpha.4.0.0