search

studiobakers / react-ui-toolkit

Bakers Studio's React-based UI Toolkit
MIT License
15 stars 2 forks source link

DropdownList: BEMify classNames #124

Closed mucahit closed 3 years ago

mucahit commented 3 years ago

Let's make the dropdown-list-item dropdown-list__empty-message-item className BEMified

 dropdown-list-item dropdown-list__empty-message-item
+dropdown-list__item dropdown-list__item__empty-message
edizcelik commented 3 years ago

I think it would be better if we create a DropdownListItem component and keep dropdown-list-item for class names. This would allow further improvement later on and it wouldn't affect the users of the component. What do you think @mucahit ?

UPDATE:

Ah my mistake. It seems we already have a DropdownListItem. Why are we changing this classname ? DropdownListItem is a separate block so I think we should keep them as dropdown-list-item.

dropdown-list__empty-message-item: this can be thought as a modifier on dropdown-list-item so maybe we can change that as dropdown-list-item--is-empty-dropdown-message

mucahit commented 3 years ago

Since this is an unnecessary change I'm closing this. Thanks for the warning @edizcelik