fix(button): Fix prop types - Githubissues

studiobakers / react-ui-toolkit

Bakers Studio's React-based UI Toolkit

MIT License

15 stars 2 forks source link

fix(button): Fix prop types #134

Closed mfarukkoc closed 2 years ago

mfarukkoc commented 3 years ago

Description

Changed forwardRef types.
Removed explicit prop type in the component definition.
const Button = React.forwardRef<HTMLButtonElement, Record<string, any>>(
const Button = React.forwardRef<HTMLButtonElement, ButtonProps>(
function ButtonComponent(props: ButtonProps, ref) {
function ButtonComponent(props, ref) {

Fixed incompatible types in the Dropdown component

Types of property ''aria-haspopup'' are incompatible.
Type '"listbox" | "menu" | "combobox"' is not assignable to type 'boolean | "listbox" | "menu" | "dialog" | "false" | "true" | "tree" | "grid" | undefined'.
  Type '"combobox"' is not assignable to type 'boolean | "listbox" | "menu" | "dialog" | "false" | "true" | "tree" | "grid" | undefined'.

Fixed typo in the passwordInput component.
ariaLabel={iconAriaLabel}
aria-label={iconAriaLabel}

Closes #133