refactor(formField): Move children outside the label

studiobakers / react-ui-toolkit

Bakers Studio's React-based UI Toolkit

MIT License

15 stars 2 forks source link

refactor(formField): Move children outside the label #141

Closed mfarukkoc closed 3 years ago

mfarukkoc commented 3 years ago

Description

Moved children prop outside the label element.

Fixes #132

jamcry commented 3 years ago

I wanted to leave a comment for future reference: This change was made at the first place because, if TypeaheadSelect is used inside a FormField, clicking the label causes auto-focus on the typeahead input, thus causing selected tag to be removed.

But we decided in the team meeting that moving children outside would be a breaking change, and we should try to find a better solution for the problem