search

studiobakers / react-ui-toolkit

Bakers Studio's React-based UI Toolkit
MIT License
15 stars 2 forks source link

Input crashes app on UC Browser #176

Closed jamcry closed 2 years ago

jamcry commented 2 years ago

getNumberSeparators are called on every locale change inside Input. That function isn't supported in some browsers (such as mobile UCBrowser), thus causing app to crash

Sentry Error (here) details:

Cannot read property 'value' of undefined {snip} THS_SEPARATOR:e.find((function(t){return"group"===t.type})).value,DECIMAL_NUMBER_SEPARATOR:e.find((function(t){return"decimal"===t.type})).v {snip}

user agent: Mozilla/5.0 (Linux; U; Android 11; en-US; LE2100 Build/RKQ1.201112.002) AppleWebKit/537.36 (KHTML, like Gecko) Version/4.0 Chrome/78.0.3904.108 UCBrowser/13.4.0.1306 Mobile Safari/537.36

yasincaliskan commented 2 years ago

Alternative sentry issue: https://sentry.io/organizations/hipo/issues/3147060839/?project=5954039&query=getNumberSeparator&statsPeriod=90d&utc=true

yasincaliskan commented 2 years ago
yasincaliskan commented 2 years ago

Should be fixed with separated NumberInput component.