Closed akgunberk closed 1 year ago
@akgunberk is it ready to review? when we can finalize this
@akgunberk is it ready to review? when we can finalize this
ready to review, we can say. we have 2 small issues i stated on description but I don't have time for this rn. we can prioritize this if this is urgent, lets discuss ✌🏼
Regarding the eslint "0n"
issue, I didn't encounter this on my local. How can I reproduce it? 🤔 @akgunberk
@akgunberk what is the status of this PR? Is it working?
@akgunberk what is the status of this PR? Is it working?
@jamcry it is on hold. there are two issues to be handled stated in description. Testing also needed, it is been a while after creating this PR.
duplicated with #228
[ ] - eslint gives error for constant numbers in
@hipo-base-config
["0n"] [ ] - storybook icon rendering plugin not workingto bypass first error for now, go to your node_modules/@hipo/eslint-config-base/common.js
replace the rule with following