studiobakers / react-ui-toolkit

Bakers Studio's React-based UI Toolkit
MIT License
15 stars 2 forks source link

feat: lib package update #215

Closed akgunberk closed 1 year ago

akgunberk commented 1 year ago

[ ] - eslint gives error for constant numbers in @hipo-base-config ["0n"] [ ] - storybook icon rendering plugin not working

to bypass first error for now, go to your node_modules/@hipo/eslint-config-base/common.js

replace the rule with following

    "no-magic-numbers": [
      "error",
      {
        ignore: [
          1,
          0,
          -1,
          // "0n"
        ]
      }
    ]
mucahit commented 1 year ago

@akgunberk is it ready to review? when we can finalize this

akgunberk commented 1 year ago

@akgunberk is it ready to review? when we can finalize this

ready to review, we can say. we have 2 small issues i stated on description but I don't have time for this rn. we can prioritize this if this is urgent, lets discuss ✌🏼

yasincaliskan commented 1 year ago

Regarding the eslint "0n" issue, I didn't encounter this on my local. How can I reproduce it? 🤔 @akgunberk

jamcry commented 1 year ago

@akgunberk what is the status of this PR? Is it working?

akgunberk commented 1 year ago

@akgunberk what is the status of this PR? Is it working?

@jamcry it is on hold. there are two issues to be handled stated in description. Testing also needed, it is been a while after creating this PR.

akgunberk commented 1 year ago

duplicated with #228