Reduce specificity within dropdown styles

studiobakers / react-ui-toolkit

Bakers Studio's React-based UI Toolkit

MIT License

15 stars 2 forks source link

Reduce specificity within dropdown styles #27

Closed edizcelik closed 3 years ago

edizcelik commented 3 years ago

~~This selector is too specific and I think we should be able to reduce its specificity~~

.dropdown-container button.dropdown-header-button

~~Also, the height property is set via the height property in this block and I think we should remove that in favour of using --button-height variable~~ This was a mistake on my side on the project.

mucahit commented 3 years ago

Is this still valid? @edizcelik

edizcelik commented 3 years ago

What I said about dropdown-header-button is invalid. However, I think we can still improve the dropdown styles a bit: has-header-box-shadow and disabled is currently nested and we can remove the nesting there by using BEM naming practices.