studioespresso / craft-mollie-payments

Easily accept online payments on your Craft website through Mollie
Other
1 stars 4 forks source link

[STU-169] Payments view is broken on Craft Pro 5.2.5 #71

Closed cookie10codes closed 1 month ago

cookie10codes commented 3 months ago

Installed the version on the Craft Pro 5.1.10 for checking out the plugin. Now our project where I'm implementing the Mollie Payments, it errors out on the payments view.

There's an update within the CP.php helper, where it's checking for the indicator class to find a matching status, but it's probably not present on the Payment element, so the value can't be fetched.

It's this piece of code inside of the craftcms/cms/src/helpers/Cp.php line 801

$config['indicatorClass'] = match ($status) {
    'pending', 'off', 'suspended', 'expired', 'disabled', 'inactive' => $status,
    default => $config['color']->value,
};

Screenshot 2024-07-04 at 14 06 22

STU-169

janhenckens commented 3 months ago

hey @cookie10codes, sorry about that! removing the status from the overview should fix that for now.

I'm working on a larger update (that includes support for Mollie Subscriptions), which also includes a fix this error, Should be out early next week

cookie10codes commented 3 months ago

No worries, happy to here it was already on your radar 👍🏼

cookie10codes commented 1 month ago

hi @janhenckens, do you know when the fix will be applied?

janhenckens commented 1 month ago

Hey @cookie10codes! Sorry about the delay, I have a client testing the subscription feature in a beta release (5.1.0-beta.3) and that is taking a bit longer than I had anticipated in July.

I'm away next week and I don't want to rush the release so I'll try to get a patch update out of fix this in the meantime.

cookie10codes commented 1 month ago

@janhenckens only if it fits your schedule tho. Enjoy you time-off :-)

janhenckens commented 1 month ago

Should be fixed in 5.0.1 @cookie10codes :)