search

studioespresso / craft-navigate

Navigate makes adding and maintaining menu's and navigations a breeze. Set what types of links a menu may contain, make multi-level navigations, built-in active-state check, custom classes per item.
https://plugins.craftcms.com/navigate
Other
26 stars 7 forks source link

Styling improvements for Craft 4.9+ #71

Closed brandonkelly closed 6 months ago

brandonkelly commented 6 months ago

Improves the tree styling, and fixes a minor styling issue that will be introduced in Craft 4.9 due to https://github.com/craftcms/cms/commit/467f295397696b6111bd07d0dcb7942bbd572fe2.

Note that the change takes advantage of a new --background-position-x CSS variable that is coming in 4.9 via that commit.

Before - Craft 4.8: (note the minor border color difference)

A tree structure before this PR, on Craft 4.8

Before - Craft 4.9:

A tree structure before this PR, on Craft 4.9

After - Craft 4.9:

A tree structure with this PR, on Craft 4.9

sonarcloud[bot] commented 6 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

janhenckens commented 6 months ago

Thanks the the PR @brandonkelly! 🙏