Fixed missing deletion of orphans of split elements

studioespresso / craft-scout

Craft Scout provides a simple solution for adding full-text search to your entries. Scout will automatically keep your search indexes in sync with your entries.

MIT License

81 stars 54 forks source link

Fixed missing deletion of orphans of split elements #289

Closed kbergha closed 4 months ago

kbergha commented 6 months ago

This fixes #259

I have not seen anything break, and orphans are now deleted as expected in the indexes I have tested manually, but I have not run any unit tests (or added any new ones), as there are no instructions on what is needed to set that up.

I can try to add unit tests if some instructions are given.

janhenckens commented 4 months ago

STU-130

janhenckens commented 4 months ago

Thanks for the PR @kbergha, I was able to reproduce the issue and your fix fixes it!

janhenckens commented 4 months ago

This slightly changes the behaviour tested in it_handles_when_the_object_field_isnt_an_array so I'm going to try to get the back to how it was previously before I release this.

janhenckens commented 4 months ago

Ok, it should be fine - just need to figure out how to rewrite the test to cover this :)