search

studioespresso / craft-scout

Craft Scout provides a simple solution for adding full-text search to your entries. Scout will automatically keep your search indexes in sync with your entries.
MIT License
81 stars 54 forks source link

feat!: upgrade `league/fractal` to 0.20 #292

Closed qrazi closed 8 months ago

qrazi commented 8 months ago

Upgrade to most recent branch of league/fractal. This makes sense to do now since craftcms/element-api has also done this upgrade in its recent 4.x line. This should probably also be ported to the v5-develop branch, or maybe only introduce with that branche?

BREAKING CHANGE: Fractal's public API has changed in classes such as \League\Fractal\Serializer\ArraySerializer

janhenckens commented 8 months ago

I think the Craft 5 release and the new major version is probably to best place to introduce this change. I'll update the base branch to develop-v5 and merge it when I prepare the next beta release later this week.

janhenckens commented 8 months ago

@zizther @qrazi Think I'll release a version 4 to go along with the Element API update that also requires this. That way they can work together on Craft 4.

qrazi commented 8 months ago

I just read about https://getcomposer.org/doc/04-schema.md#conflict, and that could probably be used on the current 3.x version? So that it helps users not upgrade to element API 4.x whilst still using Scout 3.x. What do you think?

janhenckens commented 8 months ago

3.4.1 is out with the conflict for craftcms/element-api >=4.0.0, and 4.0.0 is out the the fractal update and the version conflict for craftcms/element-api < 4.0.0.

Thanks again for the PR @qrazi!

zizther commented 8 months ago

Thanks @janhenckens