search

studioimaginaire / phue

A Python library for the Philips Hue system
Other
1.52k stars 267 forks source link

Support transitiontime for scenes #134

Closed Psychokiller1888 closed 6 years ago

Psychokiller1888 commented 6 years ago

Running a scene supports transition time. Usefull for night table lamps in the morning 😀 To use it you have to create your scene with transitiontime specified or transitiontime in run_scene will have no effect and stay at default 400ms

dsifford commented 5 years ago

Can someone push this out to PyPI?

natcl commented 5 years ago

Will have a look !

-- lecaude.com studioimaginaire.com

Le 12 août 2018 à 19:06, Derek Sifford notifications@github.com a écrit :

Can someone push this out to PyPI?

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub, or mute the thread.

dsifford commented 5 years ago

Also, now that I'm looking at this...

It looks like @Psychokiller1888 added transition_time as a parameter to the run_scene function, but forgot to ever use it (namely, forgot to pass it to either call of the activate_scene function called within). So this PR effectively does nothing.

Was that the purpose?

Psychokiller1888 commented 5 years ago

Woot? Sorry, will push it, I effectively did not push the correct branch I guess. Didn't see, because it's working on my implementation

Psychokiller1888 commented 5 years ago

It is used, on line 1157....