QueryBuilderFactory:: applyFilterOr() and QueryBuilderFactory:: applyFilterAnd() could return `ParameterCollection` object

studiomado / query-bundle

Query doctrine database from query string and provide HATEOAS responses.

MIT License

13 stars 5 forks source link

QueryBuilderFactory:: applyFilterOr() and QueryBuilderFactory:: applyFilterAnd() could return `ParameterCollection` object #137

Open sensorario opened 6 years ago

sensorario commented 6 years ago

Q	A
Bug report?	no
Feature request?	yes
QueryBundle version	2.5

Instead of return scalar types array, it could be better to return a collection of items. A

AlessandroMinoccheri commented 6 years ago

applyFilterAnd doesn't return anything, but applyFilterOr returns an array, we could create a new class called OrFilter or something similar, what do you think?