Open jeremschelb opened 2 years ago
Thanks for the proposal @jeremschelb, this looks great!
On the folder structure:
src/css
and src/js
along with the sections
and snippets
which are specific to Shopifyweb/.gitignore
and web/release-note.md
files can be deleted (the content of web/.gitignore
can be backported to .gitignore
).
in their name: .stylelintrc
and .stylelintignore
To answer your ideas:
- Reduce the number of locale files by defining the required languages and the default language during installation.
I think that EN and FR locales are a nice start. Having them both can help add more by following their example.
- Add the files related to the blog (assets, template and liquid) only if they are necessary.
I think we can start this project with these files and see our usage before taking strong decisions like this.
- Install Shopify CLI as an NPM package?
This is a good idea! But if I am not mistaken, Shopify CLI is not available as an NPM package, it must be installed globally via Homebrew. Could you check the doc to confirm this?
Could you open a PR implementing your suggested structure?
This is a good idea! But if I am not mistaken, Shopify CLI is not available as an NPM package, it must be installed globally via Homebrew. Could you check the doc to confirm this?
I think it can be installed as a dependency : https://www.npmjs.com/package/@shopify/cli
I think it can be installed as a dependency : https://www.npmjs.com/package/@shopify/cli
I am not sure this version is fully working with themes, the list of available commands is missing the one to pull/push themes.
The official Shopify doc seems to still be referencing the CLI v2, which needs to be installed with Homebrew: https://shopify.dev/themes/getting-started/create#step-1-install-shopify-cli.
You can look for more information on the v3 available via NPM and how it could work with themes.
Prerequisite
Suggested file hierarchy
Some ideas