search

studiometa / scss-toolkit

A small and configurable SCSS Toolkit to boost your project! 🚀
MIT License
5 stars 0 forks source link

Release v3.0.0 #37

Open titouanmathis opened 5 years ago

titouanmathis commented 5 years ago

All new features should be added by PR to the release/3.0.0 branch, updating this PR on master. This will allow us to follow changes and corrections for the 3.0.0 version.

Features

⚠ Nota bene This PR is based on develop for a better and simpler history, it will be merged with Git Flow on both develop and master when approved.

perruche commented 5 years ago

💡 Add a wysiwyg component ruled by multiple variables Containing all default html elements that we can find in a classic wysiwyg. This is something that we often redo from scratch, while having mostly the same set of rules. This could be done in collaboration with designers so they also have in mind the set of rules available for wysiwygs

perruche commented 5 years ago

💡 Add a guide to update from v2 to v3

titouanmathis commented 5 years ago

💡 Add whitespace helpers

w-jerome commented 5 years ago

I think this feature "commit" should be uncorrelated from the toolkit. For me the toolkit is a set of functional classes to be used on the site. It should not override html "tags" (example: "a", "img", "body", etc...). Because it is specific to a DA and not to a framework.

titouanmathis commented 5 years ago

I think this feature "commit" should be uncorrelated from the toolkit. For me the toolkit is a set of functional classes to be used on the site. It should not override html "tags" (example: "a", "img", "body", etc...). Because it is specific to a DA and not to a framework.

Yes, I think we should avoid side effects on HTML elements and stick to generating classes that can be used as needed.

What about having a .type-size-root that could be added to the <html> element?

@if $has-classes {
  // Set root font size
-  html {
+  .type-size-root {
    font-size: $font-size-root;
  }
}

Maybe we should rename the variable from $font-size-root to $type-size-root to match with all the other variables declared in this file.

@w-jerome do you feel like opening a PR to fix this? 🙂

lusimeon commented 5 years ago

@titouanmathis @w-jerome

What about having a .type-size-root that could be added to the element?

I'm ok with this ;)

Maybe we should rename the variable from $font-size-root to $type-size-root to match with all the other variables declared in this file.

I see a difference between type and font-size, so personnaly I'm not ok with this: