search

studioph / QuestsAreInSkyrimPatcher

Forwards changes from Quests Are In Skyrim to winning records
GNU General Public License v3.0
1 stars 0 forks source link

Partial patching based on ComparisonType of source Condition #1

Closed studioph closed 1 month ago

studioph commented 2 months ago

It appears that some radiant quests edited by QAIS have EqualTo as the comparison type while others have EqualTo/Or. Whichever one gets found by the search function during the first stage of the patcher will be used to check which aliases need patching, which will end up omitting quests that use the other variant of the condition.

Examples:

studioph commented 2 months ago

Not technically a bug with the underlying QuestAliasConditionUtil class from SynthesisUtils. Easiest solution is probably to search for multiple distinct conditions and simply run multiple util patcher instances for each variant.

studioph commented 2 months ago

Upon further investigation, I believe that the EqualTo/Or variant is actually incorrect having investigated the plugin in xEdit as the OR ends up nullifying the FormList check with the GetQuestRunning condition that was also added. I may update the patcher to add EqualTo as a condition of the searchFunc, but otherwise will wait to hear for a response from the mod author.

studioph commented 1 month ago

Fixed in 5d1ee35a712c5074dba1f654a0cb0cb5493dcc30