Prevent Chromium from always downloading

[kienstra]

• It looks like @wordpress/scripts@9.0.0 now defers downloading Chromium until test-e2e runs

• Also, this uses npm:puppeteer-core@3.0.0, like in Gutenberg

  How to test

  1. rm -rf node_modules
  2. npm install
  3. Expected: Chromium is not downloaded
  4. npm run build && npm run env start && npm run test:e2e
  5. Expected: Chromium is then downloaded:

Documentation

• Probably no documentation required. This should only affect the developer experience of this plugin.

Suggested changelog entry

• Prevent Chromium from downloading on npm install.

Notes

• CSS linting failed with the new @wordpress/scripts@11.0.0 package. If you like this overall approach, we can talk about whether to make the CSS conform to the new ruleset, or change the ruleset.
• The CSS linting also failed with @wordpress/scripts@9.0.0, so I thought we might as well use the more recent 11.0.0. But your call 😄

[kienstra]

Hi @mindctrl, Does this help? It should prevent Chromium from downloading on npm install, and delay it until npm run test:e2e.

Is npm run lint:css failing in your local with this PR? It is in mine, but it's a little strange it passed in CircleCI.

If it is failing and you like this PR's approach, we could discuss whether we should change the CSS ruleset, or change the CSS to conform to it.

Thanks, John!

[kienstra]

Unfortunately, this doesn't remove puppeteer from package.json.

Doing npm uninstall puppeteer-core seems to take almost as long as installing it, and npm run test:e2e fails without puppeteer.

[mindctrl]

@kienstra Nice, thanks for putting this together! ❤️

Is npm run lint:css failing in your local with this PR? It is in mine, but it's a little strange it passed in CircleCI.

Looks like we're running npm run lint:css:src in Circle, which is why it passed. But it appears that's not working as intended nowadays. It's not catching issues with files inside src. I think for now in this PR we leave the CSS linting alone and address it in a new PR.

I just ran some quick tests with npm run start and npm run build-assets, both as a standalone AB install and also with it bundled inside the latest GPB build. Blocks and other things are working as expected.

@mikemcalister can you give this a test as well?