search

studiopress / genesis-connect-woocommerce

Core plugin for developing WooCommerce integration
18 stars 14 forks source link

Make Genesis Connect notices dismissible #43

Open nickcernis opened 5 years ago

nickcernis commented 5 years ago

Gutenberg 4.3 / WP 5.0 Beta 5 now makes admin notices display in the new editor. As our notice is not dismissible, it covers the editor, forcing people to deactivate the plugin.

We should consider making the notice dismissible, or explore ways to show it only on non-editor pages.

edit_post_ _wp_beta_ _wordpress
dreamwhisper commented 5 years ago

Ref: https://github.com/WordPress/gutenberg/issues/12243

nickcernis commented 5 years ago

An issue is now raised for this in Trac, and scheduled for WP 5.0: https://core.trac.wordpress.org/ticket/45405

Depending on the results there we may not need to take further action here.

nickcernis commented 5 years ago

Looks like this will be fixed in https://github.com/WordPress/gutenberg/pull/12301 for Gutenberg 4.7.

nickcernis commented 5 years ago

The admin notices component appears to have been removed: https://github.com/WordPress/gutenberg/pull/12444

Need to retest in the final RC/release version, but it's likely that fix will resolve this.