search

studiopress / genesis-custom-blocks

A WordPress Admin interface and a simple templating system for building custom Gutenberg blocks.
GNU General Public License v2.0
82 stars 13 forks source link

Include styles in <head> instead of footer #181

Open mikemanger opened 3 months ago

mikemanger commented 3 months ago

Currently the plugin enqueues block and global block styles in the footer, this is causing some large Cumulative Layout Shift (CLS) issues across our sites. It also makes it difficult/confusing to override styles for individual blocks via the className property.

The fix should just involve moving the enqueue styles code out of the render callback and some logic to add the relevant args to the register_block_type() function call.

mikemanger commented 3 months ago

I appreciate WP Engine have stated they're not accepting enhancements/features to this plugin and that this can be achieved via hooks, however I thought I'd check if a PR would be considered before we commit developer time to this in October.🚀

mikemanger commented 2 weeks ago

We have published a shim WordPress plugin to https://packagist.org/packages/lighthouseuk/wp-gcb-block-asset-tweaks.

If there is any appetite I can submit a PR to merge in the changes.