studiopress / genesis-sample

This is the sample theme created for the Genesis Framework.
https://demo.studiopress.com/genesis-sample/
534 stars 280 forks source link

Restore all layouts, remove or add option to disable fixed header #182

Open nickcernis opened 5 years ago

nickcernis commented 5 years ago

If Genesis Sample is intended as a reference theme that other developers can use as a starting point for their own themes, I think it should:

That way developers can strip what they don't want, instead of having to craft code for features Genesis supports that Sample has left out.

It also sets us up better for https://github.com/studiopress/genesis-sample/issues/142, where a custom starter theme will be able to be generated from chosen features.

This is something that's echoed by the Genesis community. From Slack:

BP [9 hours ago] I would have liked a different approach to the sample theme myself but that's a whole different rabbit hole.

LA [9 hours ago] In what way?

LA [9 hours ago] I’ve been messing around with it trying to figure out the best way to setup a new starter theme

LA [9 hours ago] It’s at a hard stage right now because of the transition into all the planned features

BP [9 hours ago] I think my favorite was version 2.3. Menus in traditional locations. No fixed header. Displayed menu below header, Layouts not removed, etc. I think the sample theme should be simple but still show all basic features that parent theme provides. Just my opinion. (edited)

LA [9 hours ago] That’s a good point. I’ve had quite a few customers say the same thing.

artmaug commented 5 years ago

+1