Can't set configs on Windows

studiorack / studiorack-cli

Audio project manager for handling DAW VST plugin dependencies

https://studiorack.github.io/studiorack-site

MIT License

23 stars 1 forks source link

Can't set configs on Windows #3

Closed derkrasseleo closed 2 years ago

derkrasseleo commented 2 years ago

I can't set the pluginFolder path and also, when I change it in the app it doesn't reflect the change in the cli. This could be a windows specific issue tho.

edit: also doesn't work without "" or with /

derkrasseleo commented 2 years ago

Setting other properties, like projectFolder also doesn't work.

kmturley commented 2 years ago

Which version of the cli are you using?

studiorack --version

It might be that you are running an old version. It's working for me! Screenshot 2022-05-06 161154

kmturley commented 2 years ago

This commit will automatically update the StudioRack cli if it detects that it is out-of-date: https://github.com/studiorack/studiorack-core/commit/105f31fc5ded50662a663b936892c25360f6ee0c

Will test this in a new release soon

derkrasseleo commented 2 years ago

I was on version 1.1.12 and upgraded. to 1.1.15. I can now set the configs in the cli, but the change is not reflected in the GUI. Also, when I change the path in the GUI, the path in the cli doesn't change.

kmturley commented 2 years ago

This should be fixed in the latest release. Update using: npm install @studiorack/cli@latest -g

derkrasseleo commented 2 years ago

This should be fixed in the latest release. Update using: npm install @studiorack/cli@latest -g

Does it not auto-update the cli when updating the app? If not, that would be a nice addition.

derkrasseleo commented 2 years ago

But the issue itself seems to be fixes, nice work!

kmturley commented 2 years ago

Nesting the CLI tool inside the App was a bad idea of mine. It was causing all sorts of issues:

Versions were different
User could install a different version while the App was open
App upgrading the CLI would change it for the entire computer
Could not run different versions of the App on the same computer
App and CLI could run different versions of the core library which would cause bugs

I reverted to my original approach where there is a mini CLI type script which can be run as part of the core library.

This decouples the App and the CLI tool, and ensures the core library code is shared.

So CLI tool is not used at all by the App. You can uninstall and the App will still function