studiosnack / brews-clues

Have you seen my brew?
0 stars 0 forks source link

Add redux, react-redux and auth actions/reducer #10

Closed nsfmc closed 7 years ago

nsfmc commented 7 years ago

ok, so this is a pretty unfortunately large pr, but it is somewhat reasonable to read-through commit by commit. part of this is the nature of redux, part of it is the nature of auth being very complex even when it's easy.

So mostly, the important thing is as you're skimming this, ask any questions that you have or any time you're like "why did you do that?" and i will field that right away.

also, i noticed that like ~20% of the time, firebase drops the connecttion to twitter and auth fails. it's pretty wild, i mean, whatever, i'm not paying for this, but it's a pretty high number. maybe it's just that it's so late?