studywolf / blog

for code created as part of http://studywolf.wordpress.com
GNU General Public License v3.0
266 stars 235 forks source link

Typo within self.J_orientation #3

Closed sirop closed 7 years ago

sirop commented 7 years ago
self.J_orientation = [[0, 0, 10],  # joint 0 rotates around z axis
                          [10, 0, 0],  # joint 1 rotates around x axis
                          [10, 0, 0],  # joint 2 rotates around x axis
                          [10, 0, 0],  # joint 3 rotates around x axis
                          [0, 0, 10],  # joint 4 rotates around z axis
                          [1, 0, 0]]  # joint 5 rotates around x axis

I guess the orientation axis should be normed, so 10 ->1 .

studywolf commented 7 years ago

correct! thanks! this all needs to be updated, actually. I'm going to be releasing another repo with these fixes and issues hopefully in the next month or two, but I'll fix it here in the mean time. Thanks for the catch!