search

stuerp / foo_midi

A foobar2000 component to play MIDI files.
MIT License
59 stars 1 forks source link

Invisible tick in checkboxes (custom theme) #26

Closed d-bind closed 10 months ago

d-bind commented 10 months ago

I'm using a custom Windows 10 theme, with foobar in light mode, and since foo_midi v2.7.4.1 (that added dark mode support), the checkboxes look the same whether they're ticked or not. Previously they used a different-looking UI element.

If I switch foobar to dark mode, the check marks become visible against dark background, but I'd prefer to avoid foobar's dark mode. On paper, seems like light mode UI should have been unaffected by 2.7.4.1 changes, but I'm not sure if this is something under your control. Can you make the light mode use the old checkbox element?

Since this is basically a self-inflicted problem on my part, feel free to close this if it's a hassle. But also: the text doesn't fit in the box since the UI reshuffle.

2.7.4.0 2.9.1.3 light 2.9.1.3 dark

stuerp commented 10 months ago

The dark mode is implemented by foobar2000 itself by hacking the theme and rendering code of all controls on a dialog. It takes one line of code to support it in a component. If I step away from that I'd have to reimplement all that code myself.

d-bind commented 10 months ago

Understandable. And if it's one line I can simply compile my own version.