search

stuerp / foo_sid

A foobar2000 component to play SID and MUS files.
GNU General Public License v2.0
6 stars 2 forks source link

Fixes blocked playback caused by a bug related to extracting the genre from the song file path. #7

Open rlnilsen opened 1 month ago

rlnilsen commented 1 month ago

TuneInfo->path() and SongLengths.md5 path can differ in case and would in that case break the code extracting the genre from the song file path. Fixed by dropping the entire genre reading functionality, I argue that this is acceptable as the value extracted is not really the genre of the song and the information is anyway not too useful.

Closes #6.

Edit: capitalization -> case

rlnilsen commented 1 month ago

Specifically, on line 626 genre.find(_StilBaseDir) would return npos and cause genre.replace(...) to throw an exception.

rlnilsen commented 1 month ago

Just realized I used the wrong word in the PR description. I wrote "capitalization" but meant "case". Sorry for the confusion.