stuerp / foo_vis_spectrum_analyzer

A foobar2000 component that displays a spectrum analyzer.
MIT License
20 stars 0 forks source link

High number of bands make certain frequencies "fall" when paused #36

Closed WagnerGFX closed 8 months ago

WagnerGFX commented 8 months ago

Where?

How it's working now:

freq bands

Expected behavior:

System Info:

Note:

stuerp commented 8 months ago

Thank for your detailed report but I am unable to reproduce this. Even at the maximum setting of 512 with various sample rates the spectrum gets calculated correctly.

WagnerGFX commented 8 months ago

Thank for your detailed report but I am unable to reproduce this. Even at the maximum setting of 512 with various sample rates the spectrum gets calculated correctly.

I thought it was the number of bands, but after testing other options, I've found that the settings in Transform seem to affect this much more.

transform

Window Functions affected:

No. of Bins = 8192 or lower Mapping = Standard Enable Smooth lower Frequencies

stuerp commented 8 months ago

Tried to reproduce this without success. Could you attach a preset file with the settings that cause this issue?

WagnerGFX commented 8 months ago

bands presets.zip

BandsTest result in the bands showing a hole like below:

bands result

BandsMinimum should result in nearly nothing showing:

bands minimum

stuerp commented 8 months ago

Not here. This is BandsMinimum: image

WagnerGFX commented 8 months ago

Not here. This is BandsMinimum

It's not fair if you fix the issue before taking the screenshot 🤣 The alpha version doesn't present the issue for me too, maybe it was the side effect of another issue.

The only change I noticed is that whenever I change the settings while paused, all bars disappear until I resume playing the song. It's nothing critical, but it gets harder to evaluate subtle changes.

stuerp commented 8 months ago

Not here. This is BandsMinimum

It's not fair if you fix the issue before taking the screenshot 🤣 The alpha version doesn't present the issue for me too, maybe it was the side effect of another issue.

Not intentionally. This version contains a couple code cleanups to make sure the spectrum amplitudes have a 0. to 1. value right before rendering starts, But it should have been a refactoring move without side effects. Luckily this time it seems there was a positive side effect.

The only change I noticed is that whenever I change the settings while paused, all bars disappear until I resume playing the song. It's nothing critical, but it gets harder to evaluate subtle changes.

That's due to the spectogram code, which is still in the alpha stage. It needs a continuous time axis and fb2k produced weird time information when switching tracks. The joy of developing without any SDK documentation...

WagnerGFX commented 8 months ago

Not intentionally. This version contains a couple code cleanups to make sure the spectrum amplitudes have a 0. to 1. value right before rendering starts, But it should have been a refactoring move without side effects. Luckily this time it seems there was a positive side effect.

The bands seem more "responsive" now. Overall, the cleanup was great.

The joy of developing without any SDK documentation...

I can relate to that 😂 / 😭

Given that it's been fixed on v0.7.5.0-alpha1, I'll close it as fixed. 👍