The network data handler currently located in the game module has the smell of legacy. The core functionality is modeled based off of the old "Dockyard" project, which itself was an implementation to the notes of "it works, move on", while investigating the debugger protocol in Electron.
Clean up the structure of the code, and split up the functionality into isolated pieces of code that can do work on their own, independent of others.
Additionally, investigate why the debugger events aren't Kefir streams, and if there is a way, convert those. This should help keep the code a little bit cleaner in terms of managing event subscriptions and when having to dispose of said event streams (in contrast to .on/.off etc).
stuf
commented
7 years ago
The network data handler currently located in the
gamemodule has the smell of legacy. The core functionality is modeled based off of the old "Dockyard" project, which itself was an implementation to the notes of "it works, move on", while investigating the debugger protocol in Electron.Clean up the structure of the code, and split up the functionality into isolated pieces of code that can do work on their own, independent of others.
Additionally, investigate why the debugger events aren't Kefir streams, and if there is a way, convert those. This should help keep the code a little bit cleaner in terms of managing event subscriptions and when having to dispose of said event streams (in contrast to
.on/.offetc).