stuffbyrae / scrapbook

A simple screenshot viewer for Playdate!
2 stars 0 forks source link

keyrepeat timers need to be called off if changing inputhandlers #19

Closed stuffbyrae closed 1 year ago

stuffbyrae commented 1 year ago

If a keyrepeat timer button is held down, and then the input handler is changed (e.g. opening the viewer), the keyrepeat timer will keep going and scrolling through until and unless the inputhandler is repushed while the offending button is being held down, and then the button is released after the input handler is pushed. these should be called off manually when changing input handlers, to dodge the problem altogether. if this is done when switching from viewer back to gallery, the viewer image will Flash on screen temporarily due to how the function is handled. we can likely remove that additional draw call outside of the update loop. The keyrepeat timer will also loop through the columns, which shouldn't happen using D-pad controls