search

stuffbyrae / scrapbook

A simple screenshot viewer for Playdate!
13 stars 0 forks source link

Clicking left-right in gallery view makes move sound even if the cursor doesn't move #5

Closed stuffbyrae closed 1 year ago

stuffbyrae commented 1 year ago

If you're up against one of the left or right "walls" of the gallery view, clicking the direction that moves into that wall will make the proper left or right sound effect instead of the locked-out bonk noise.

scratchminer commented 1 year ago

Why can't the seleciton wrap if you're up against the wall? There's even a parameter for that in gridview.

stuffbyrae commented 1 year ago

I had it on before at some point, i think turning it on makes it so that reaching the end makes it wrap around to the top which might fuck with shit

scratchminer commented 1 year ago

What if, instead of passing a constant boolean to the wrap parameter, we passed row == (#pics // 2)? That'd fix it so it wouldn't wrap when scrolling past the end

stuffbyrae commented 1 year ago

:thonk emoji?: yeah totes go for that if it works, i'm too tired to fire up VScode any more today hahahaha. feel free to commit and close this if that ends up kosher