search

stuffmatic / fSpy

A cross platform app for quick and easy still image camera matching
https://fspy.io
GNU General Public License v3.0
2.25k stars 214 forks source link

Scaling issue with Blender 2.8, fSpy 1.0.1, and fSpy-Blender 1.0.1 #5

Closed mvittiglio closed 5 years ago

mvittiglio commented 5 years ago

I tried using a toy box in the room to generate my reference points, etc but it seems like the scales got a bit messed up. Here is the

https://www.youtube.com/watch?v=Hqf5xuXHBa4&t=2s https://imgur.com/FbCfnOQ

stuffmatic commented 5 years ago

Had a closer look at this and managed to reproduce the issue. Seems to happen when manually changing the units of the scene. Properly setting the distance unit is on my todo list for the next release. Not sure how I managed to forget it for the first 2.8 release... 🙈

Here's an import I made without messing with the units, where the plane of width 1 matches the specified reference distance well.

screen shot 2018-12-03 at 21 54 17

By the way, I wish all bug reports looked like this! 🥇

mvittiglio commented 5 years ago

I'll try to stick to metric units then (convert on my end). Also, not sure if you know but the update to 1.0.1 breaks compatibility with 2.79b.

Thanks for the compliment. I come from a development background and do support work now; I WANT you to know how to break it (or tell me how I'm doing it wrong).

I know this is a bigger question than it seems but is there an ETA on the next release?

P Please consider the environment before printing this e-mail.

On Mon, Dec 3, 2018 at 4:12 PM Stuffmatic notifications@github.com wrote:

Had a closer look at this and managed to reproduce the issue. Seems to happen when manually changing the units of the scene. Properly setting the distance unit is on my todo list for the next release. Not sure how I managed to forget it for the first 2.8 release... 🙈

Here's an import I made without messing with the units, where the plane of width 1 matches the specified reference distance well.

[image: screen shot 2018-12-03 at 21 54 17] https://user-images.githubusercontent.com/2444852/49401119-83742b00-f746-11e8-9d1e-a6d1bd46eb9f.png

By the way, I wish all bug reports looked like this! 🥇

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/stuffmatic/fSpy/issues/5#issuecomment-443871996, or mute the thread https://github.com/notifications/unsubscribe-auth/AA8-_q6C2NH7mtB8eQBQP4vm0TiOs86Jks5u1ZPDgaJpZM4Y-3JX .

stuffmatic commented 5 years ago

I've released a new version of the importer that should handle reference distance units properly. The 2.79 crash should be fixed too. There's also a new version of fSpy with a more sensible list of units, so I recommend you use that.

mvittiglio commented 5 years ago

Holy crap! Super fast!

Thanks a bunch. Playing with it now and I'll let you know if I come into any issues.

Heads up, I created another issue (feature request really) asking for an "about" dialog to see what version is currently installed, etc.

P Please consider the environment before printing this e-mail.

On Tue, Dec 4, 2018 at 5:10 AM Stuffmatic notifications@github.com wrote:

I've released a new version of the importer that should handle reference distance units properly. There's also a new version of fSpy with a more sensible list of units

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/stuffmatic/fSpy/issues/5#issuecomment-444045173, or mute the thread https://github.com/notifications/unsubscribe-auth/AA8-_r9CedxZv1eaVej-foPKVLBZNcKPks5u1kocgaJpZM4Y-3JX .

stuffmatic commented 5 years ago

Closing this. Let me know if the issue persists.

mvittiglio commented 5 years ago

Just a heads up, I thought that the issue was still present but it seems that the installer doesn't remove the previous version. I could just be crazy but I'm almost certain that I ran the right installer. Just some food for thought. Works now and thanks so much.

P Please consider the environment before printing this e-mail.

On Tue, Dec 4, 2018 at 2:52 PM Stuffmatic notifications@github.com wrote:

Closed #5 https://github.com/stuffmatic/fSpy/issues/5.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/stuffmatic/fSpy/issues/5#event-2005309878, or mute the thread https://github.com/notifications/unsubscribe-auth/AA8-_otxKfyL0bTrRaJpPS87LbfKJTkDks5u1tKBgaJpZM4Y-3JX .

wasd commented 5 years ago

I am using 1.0.3 with Blender 2.79b. I save file with reference distance in centimeters, but camera position in blender imported in meters.