search

stujones11 / minetest-3d_armor

Visible player armor & wielded items for minetest
Other
56 stars 98 forks source link

New character models for needed for MT after #6007 #112

Closed lhofhansl closed 7 years ago

lhofhansl commented 7 years ago

Fixed character models for MT after #6007

stujones11 commented 7 years ago

Thanks, though I have already made alternative models available for those that wish to continue using development builds https://forum.minetest.net/viewtopic.php?f=11&t=4654&start=650#p284858

I will probably add a feature branch once settable player collision boxes are fully integrated into MTG with any changes to the player model that are currently being proposed https://github.com/minetest/minetest_game/pull/1411

Wuzzy2 commented 7 years ago

Keep in mind that if you merge this, you will break compability with 0.4.16. I would wait with merging this until Minetest 0.5.0 is released.

stujones11 commented 7 years ago

Keep in mind that if you merge this, you will break compatibility with 0.4.16

This is why I intend to merge this into a feature branch instead. For you can now simply substitute 3d_armor_character.b3d with the updated version.

lhofhansl commented 7 years ago

Feel free to close this one then.

stujones11 commented 7 years ago

Feel free to close this one then.

No need, I am sure your changes are fine and I can eventually merge them to a new branch. In the meantime your fork provides an alternative upgrade path for others.

lhofhansl commented 7 years ago

I think you might want to take your updated models. I can update this PR accordingly. (I'm no expert in Blender)

stujones11 commented 7 years ago

Okay, there was a problem with the models not being exported correctly anyway, not sure about yours but the latest version has been tested with advanced lighting.