search

stujones11 / minetest-3d_armor

Visible player armor & wielded items for minetest
Other
56 stars 98 forks source link

error #121

Closed ValkyrieStella closed 6 years ago

ValkyrieStella commented 7 years ago

im getting this occasionally when people joins.

3d armour causes internal error.

logs:

2017-08-21 19:50:43: ERROR[Main]: ServerError: AsyncErr: ServerThread::run Lua: Runtime error from mod 'simple_skins' in callback on_joinplayer(): ...n/../games/minetest_game/mods/armor/3d_armor/api.lua:199: bad argument #1 to 'pairs' (table expected, got nil) 2017-08-21 19:50:43: ERROR[Main]: stack traceback: 2017-08-21 19:50:43: ERROR[Main]: [C]: in function 'pairs' 2017-08-21 19:50:43: ERROR[Main]: ...n/../games/minetest_game/mods/armor/3d_armor/api.lua:199: in function 'armor_org_func' 2017-08-21 19:50:43: ERROR[Main]: ...table/bin/../games/minetest_game/mods/hud/legacy.lua:26: in function 'set_player_armor' 2017-08-21 19:50:43: ERROR[Main]: ...in/../games/minetest_game/mods/simple_skins/init.lua:121: in function 'update_player_skin' 2017-08-21 19:50:43: ERROR[Main]: ...in/../games/minetest_game/mods/simple_skins/init.lua:140: in function '?' 2017-08-21 19:50:43: ERROR[Main]: ...top/minetest-stable/bin/../builtin/game/register.lua:412: in function <...top/minetest-stable/bin/../builtin/game/register.lua:392>

stujones11 commented 7 years ago

That error looks to originate from the simple_skins mod, however, it is more likely due to recent changes to the core and official game. Please note that this mod only officially supports up to minetest 0.4.16-stable. To investigate this any further I'd need to know which versions of the game and this mod you are actually using.

ValkyrieStella commented 7 years ago

im using the latest 0.4.16 stable version, not the development. and the mod is updated to the latest

stujones11 commented 7 years ago

Okay, I will tag this as a bug until I have time to investigate further, thank you for the report.

stujones11 commented 6 years ago

d5896a04e2d3f755bec0a4171c597362747b2984 should prevent the crash, however, I suspect this is caused by simple_skins attempting to set the player armor before it has properly initialized, I guess the worst outcome now is that you don't get the right skin.