Add an option regarding the admin shield's on_punched() callback

stujones11 / minetest-3d_armor

Visible player armor & wielded items for minetest

Other

56 stars 98 forks source link

Add an option regarding the admin shield's on_punched() callback #131

Closed IhrFussel closed 6 years ago

IhrFussel commented 6 years ago

I recommend to add an option to turn off the default behavior of admin shields, which destroys the tool of the attacker.

This behavior is not wanted on my server and many other servers don't need it either.

It should be the server owner's choice whether or not player items should get destroyed in on_punch().

stujones11 commented 6 years ago

I honestly don't see how this would be a problem, why would anyone be stupid enough to do this more than once, lol. TBH it was just added as an example of the new api (about 3 versions ago) but it could be a handy defence against admin tools/weapons that may have fallen into the wrong hands ;^)

However, I do not consider this worth adding another option for. I will remove this functionally sometime over the weekend, It has fulfilled its purpose as far as I'm concerned :)

Ezhh commented 6 years ago

@stujones11 Thank you - I'd also like this removed. If a player can't hurt me, I honestly don't mine them trying to. If it annoys me and they ignore warnings, I can always teleport them straight into the nearest pool of lava after all. :)