search

stujones11 / minetest-3d_armor

Visible player armor & wielded items for minetest
Other
56 stars 98 forks source link

Use preview method for unified inventory #152

Closed bell07 closed 6 years ago

bell07 commented 6 years ago

I found this during porting the 3d_armor to player_api ;-)

stujones11 commented 6 years ago

This looks fine, although that function no longer exists in the multiskin branch and was supposed to be provided by the multiskin mod. However, in the light of your player_api, I might consider depending on that instead :)

bell07 commented 6 years ago

Oh, I did not seen the method "get_preview()" obsolete. The method provides the preview + fallback texture. Using the method all inventory mods do not need directly dependency to the skin/preview providers mods (+player_api). Just further dependency on 3d_armor only.