search

stujones11 / minetest-3d_armor

Visible player armor & wielded items for minetest
Other
56 stars 98 forks source link

make fire protect a default option #166

Closed fluxionary closed 5 years ago

fluxionary commented 5 years ago

This PR is more of a question.

It seems that the major reason that fire protection isn't enabled by default is because when it is, 3d_armor entirely overrides the calculation of fire damage, and fire damage is only calculated for a hard-coded list of nodes.

However, I'm working with Terumoc on the terumet mod (https://github.com/terumoc/terumet) (well, Terumoc is doing most of the work), and we're discussing the most sensible way to add fire protection to the armor in that mod. One option, of course, is just to ask server owners to create a setting to enable fire protection. Another is to change the default - but this makes it so that torches damage players by default, and possibly misses other fire damage nodes added by arbitrary mods. A third option is to add terumet to the mods in which fire protection is enabled by default.

I'm wondering if you, the mod maintainer, as any additional insight. Also, it seems like being able to add/remove nodes as sources of fire damage should be part of the 3d_armor API. I can add that to this PR if desired.

LoneWolfHT commented 5 years ago

I'd like to be able to enable fire protection for my lavastuff mod (It gives lava immunity when ethereal is enabled). It might be nice if you could add something to the API

fluxionary commented 5 years ago

Hm. I guess I wasn't paying attention to which repos I was pushing to; I had intended the "fire damage below your feet" to be a different PR. But either way, I think it's great. no longer can you sneak over lava, and you can configure some nodes to damage the player if they stand on them (e.g. fake_fire:embers, cavereals:hot_cobble).

fluxionary commented 5 years ago

I've found other ways to do what this PR does, and it's kind of poorly worded and implemented. Closing.