search

stujones11 / minetest-3d_armor

Visible player armor & wielded items for minetest
Other
56 stars 98 forks source link

Player still takes Damage even when "Enable Damage" setting is false #173

Open CBugDCoder opened 4 years ago

CBugDCoder commented 4 years ago

I know this is a counter-intuitive bug because there is no benefit to armor if damage is disabled but, I am working on a custom game for my family and it includes 3d_armor and while I am testing I have damage disabled to allow for easy mapgen testing without having to worry about dying. Unfortunately I am still dying whenever I fall from a great height or fly through lava. I have tested this to see if it is a MT bug but it only occurs when I have 3d_armor enabled so I am certain that it is this mod that is causing the problem to surface.

I haven't had a chance to look through the code of 3D_armor to find a solution yet but once I do if I can fix it I will open a PR.

redblade7 commented 4 years ago

I have 3d_armor (along with xtraarmor) installed on the no-damage server Creative Gardens for cosmetic/fun purposes.

There was some discussion on the forum about this, more info and a fix:

https://forum.minetest.net/viewtopic.php?f=6&t=23533#p360616

big-caballito commented 4 years ago

I Also Have this issue

Lapis-Wolf commented 4 years ago

I have the same issue. I was just going to post the issue here as well.

bell07 commented 4 years ago

I think it is the same issue reported in https://github.com/bell07/minetest-game-whynot/issues/15 and https://git.minetest.land/Wuzzy/MineClone2/issues/604. Looked trough MineClone2 commits and found this one: https://git.minetest.land/Wuzzy/MineClone2/commit/bab4529e4dbcd130bcd516b82e13370dd807d170 Patch from Wuzzy's Fork cannot be applied without changes to the upstream version but needs to be implemented in other way. @stujones11 ?