search

stujones11 / minetest-3d_armor

Visible player armor & wielded items for minetest
Other
56 stars 98 forks source link

Armor not getting damaged when punched by any mobs. #177

Open LandonAConway opened 4 years ago

LandonAConway commented 4 years ago

Regardless of which mob mod, or any armor you are wearing, armor is not getting damaged in any way shape or form when bieng punched by mobs. This is frustrating. Please fix it.

LoneWolfHT commented 4 years ago

https://github.com/minetest-mods/3d_armor has taken up maintaining this until stu returns from the dead. Can you reproduce the bug with that version?

ghost commented 4 years ago

3d_armor.tar.gz

LandonAConway commented 4 years ago

I have discovered the issue in the api.lua. The reason why this is happening is because the armor is not programmed to become damaged unless the "puncher" object, is a player. Since mobs are not players, they cannot damage armor unless you input a player in the punch method that is commonly executed for a mob to attack. This is not practical since mobs are so popular. Mobs should be able to interact with armor too. I'm not sure what this person was thinking but it needs to be changed.

LoneWolfHT commented 4 years ago

Was it changed in the minetest-mods repo I linked @LandonAConway ?

sirrobzeroone commented 3 years ago

cross reference https://github.com/minetest-mods/3d_armor/issues/24

mckaygerhard commented 2 years ago

I have discovered the issue in the api.lua. The reason why this is happening is because the armor is not programmed to become damaged unless the "puncher" object, is a player. Since mobs are not players, they cannot damage armor unless you input a player in the punch method that is commonly executed for a mob to attack. This is not practical since mobs are so popular. Mobs should be able to interact with armor too. I'm not sure what this person was thinking but it needs to be changed.

he issue https://github.com/minetest-mods/3d_armor/issues/57 may be related to? it defines on_punched and means to set damage to true! . damage never get true.. as i know event if that is own 3d_armor definition.. there's no such callback on minetest api